Update bower.json to fix archieml dependency #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stumped me for an hour: Using the current version of doctop and the provided archieml.js dependency (0.1.1), arrays were not being returned properly, e.g.: https://jsfiddle.net/phillipadsmith/nzxhvpjn/ However, updating to archieml.js 0.3.1 returned the expected results: http://jsfiddle.net/phillipadsmith/ov16Leoh/ Given that archieml is a dependency for using the ArchieML parsing, I would propose updating the dependency! :) Hope this helps.
|
Does ArchieML still not have a bower.json? For shame! 😄 That's brilliant, thank you very much for looking into that! Merging! 👍 |
aendra-rininsland
pushed a commit
that referenced
this pull request
Sep 23, 2015
Update bower.json to fix archieml dependency
Ha! Good point. I'll check and report something there if that's still the case. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stumped me for an hour:
Using the current version of doctop and the provided archieml.js dependency (0.1.1), arrays were not being returned properly, e.g.:
https://jsfiddle.net/phillipadsmith/nzxhvpjn/
However, updating to archieml.js 0.3.1 returned the expected results:
http://jsfiddle.net/phillipadsmith/ov16Leoh/
Given that archieml is a dependency for using the ArchieML parsing, I would propose updating the dependency! :)
Hope this helps.